From e61268c454d463940fcb2b318f68592186b1e0bc Mon Sep 17 00:00:00 2001 From: Thomas Veerman Date: Mon, 24 Sep 2012 15:25:37 +0000 Subject: [PATCH] TTY: printer better diagnostics .tell when a line is not initialized .don't print when a request has failed, we use error codes for that --- drivers/tty/rs232.c | 4 +++- drivers/tty/tty.c | 2 -- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/tty/rs232.c b/drivers/tty/rs232.c index 65237f889..4a5813439 100644 --- a/drivers/tty/rs232.c +++ b/drivers/tty/rs232.c @@ -444,7 +444,9 @@ void rs_init(tty_t *tp) * for all requests on it from userland. (The kernel will use it.) */ if(env_get_param(SERVARNAME, l, sizeof(l)-1) == OK && atoi(l) == line) { - return; + printf("TTY: not initializing rs232 line %d (in use by kernel)\n", + line); + return; } rs = tp->tty_priv = &rs_lines[line]; diff --git a/drivers/tty/tty.c b/drivers/tty/tty.c index a42c0b40f..206498f57 100644 --- a/drivers/tty/tty.c +++ b/drivers/tty/tty.c @@ -258,8 +258,6 @@ int main(void) /* If the device doesn't exist or is not configured return ENXIO. */ if (tp == NULL || ! tty_active(tp)) { - printf("Warning, TTY got illegal request %d from %d\n", - tty_mess.m_type, tty_mess.m_source); if (tty_mess.m_source != LOG_PROC_NR) { tty_reply(TASK_REPLY, tty_mess.m_source, -- 2.44.0