From: Erik van der Kouwe <erik@minix3.org>
Date: Wed, 8 Jun 2011 19:19:45 +0000 (+0000)
Subject: Globally enable -Wall warnings for GCC
X-Git-Tag: v3.2.0~543
X-Git-Url: http://zhaoyanbai.com/repos/doc/roff.7.html?a=commitdiff_plain;h=c2da8cb53508f9c3f6f73b0f6a4c8f8127f6c395;p=minix.git

Globally enable -Wall warnings for GCC
---

diff --git a/commands/elle/Makefile b/commands/elle/Makefile
index 8cc771897..d93dfe5d1 100644
--- a/commands/elle/Makefile
+++ b/commands/elle/Makefile
@@ -6,7 +6,7 @@ SRCS.elle= eemain.c eecmds.c eesite.c eevini.c eedisp.c eeterm.c eeerr.c  \
       eef2.c eefd.c eehelp.c eekmac.c eef3.c eesrch.c eequer.c \
       eefill.c eediag.c sbstr.c sbm.c sberr.c
 SRCS.ellec= ellec.c
-CPPFLAGS+= -DIGN_JOB_CONTROL -wa
+CPPFLAGS+= -DIGN_JOB_CONTROl
 MAN.elle=
 MAN.ellec=
 
diff --git a/commands/find/Makefile b/commands/find/Makefile
index ec8f99c60..5cbcfd73a 100644
--- a/commands/find/Makefile
+++ b/commands/find/Makefile
@@ -6,8 +6,6 @@
 PROG=	find
 SRCS=	find.c function.c ls.c main.c misc.c operator.c option.c
 
-CFLAGS += -Wall
-
 LDADD+=-lutil
 DPADD+=${LIBUTIL}
 
diff --git a/commands/grep/Makefile b/commands/grep/Makefile
index cd28a33f7..8aa2ff9c7 100644
--- a/commands/grep/Makefile
+++ b/commands/grep/Makefile
@@ -19,7 +19,6 @@ LDADD=  -lz
 DPADD=  ${LIBZ}
 
 .if ${COMPILER_TYPE} == "gnu"
-CFLAGS+= -Wall
 CPPFLAGS+= -isystem ../../../include
 .endif
 
diff --git a/drivers/at_wini/at_wini.c b/drivers/at_wini/at_wini.c
index 21c5fe1a1..3577b9dad 100644
--- a/drivers/at_wini/at_wini.c
+++ b/drivers/at_wini/at_wini.c
@@ -399,8 +399,6 @@ PRIVATE void init_drive(struct wini *w, int base_cmd, int base_ctl,
 }
 
 PRIVATE int quirkmatch(struct quirk *table, u8_t bcr, u8_t scr, u8_t interface, u16_t vid, u16_t did) {
-	int i = 0;
-
 	while(table->vendor) {
 		if(table->vendor == vid && table->device == did &&
 			table->pci_class == bcr &&
diff --git a/drivers/dec21140A/Makefile b/drivers/dec21140A/Makefile
index d86b181ab..09bdba94c 100644
--- a/drivers/dec21140A/Makefile
+++ b/drivers/dec21140A/Makefile
@@ -12,6 +12,6 @@ MAN=
 BINDIR?= /usr/sbin
 
 debug=		0
-CPPFLAGS+=	-Ddebug=${debug} -ws -w -Wall
+CPPFLAGS+=	-Ddebug=${debug} -w
 
 .include <bsd.prog.mk>
diff --git a/servers/devman/Makefile b/servers/devman/Makefile
index 1a6840e66..a839f535f 100644
--- a/servers/devman/Makefile
+++ b/servers/devman/Makefile
@@ -10,4 +10,3 @@ INSTALLFLAGS+=	-S 128k
 
 MAN=
 .include <bsd.prog.mk>
-CFLAGS += -Wall
diff --git a/servers/lwip/Makefile b/servers/lwip/Makefile
index 34afd7f53..728984673 100644
--- a/servers/lwip/Makefile
+++ b/servers/lwip/Makefile
@@ -21,6 +21,6 @@ BINDIR?= /usr/sbin
 CPPFLAGS+=  -I${.CURDIR} -D_MINIX -D_SYSTEM
 CPPFLAGS+= -I${.CURDIR}/../../lib/liblwip/include
 
-CFLAGS += -Wall -Wextra -std=c99
+CFLAGS += -Wextra -std=c99
 
 .include <bsd.prog.mk>
diff --git a/servers/vm/Makefile b/servers/vm/Makefile
index 511b29d93..ca6ef54d6 100644
--- a/servers/vm/Makefile
+++ b/servers/vm/Makefile
@@ -16,9 +16,6 @@ INSTALLFLAGS+=	-S 128k
 
 CPPFLAGS+= -I${.CURDIR} -I${.CURDIR}/arch/${ARCH}
 CPPFLAGS+=	-I${MINIXSRCDIR}
-.if ${CC} == gcc
-CFLAGS+= -Wall -Werror
-.endif
 
 .include "arch/${ARCH}/Makefile.inc"
 .include <bsd.prog.mk>
diff --git a/share/mk/bsd.gcc.mk b/share/mk/bsd.gcc.mk
index 66ee4ee40..e132ae809 100644
--- a/share/mk/bsd.gcc.mk
+++ b/share/mk/bsd.gcc.mk
@@ -1,2 +1,2 @@
 AFLAGS+=-D__ASSEMBLY__ -D_EM_WSIZE=4
-CFLAGS+= -fno-builtin
+CFLAGS+= -fno-builtin -Wall